Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): remove duplicate keys in wallet-rpc.md #1553

Merged

Conversation

theborakompanioni
Copy link
Contributor

@theborakompanioni theborakompanioni commented Sep 19, 2023

Resolves #1552.

This is a hot fix to make the api docs served at https://joinmarket-org.github.io/joinmarket-clientserver/api/ work again.

Removes

'401':
  $ref: "#/components/responses/401-Unauthorized"

in favor of

'401':
  $ref: '#/components/responses/401-AuthenticationError'

when both are present.

This PR does not remove response 401-Unauthorized completely, as it is still used and I am not totally sure which one of them is actually returned.

How to test

cd docs/api
python3 -m http.server 9999

Then visit http://localhost:9999 and verify that the page loads as expected.

@theborakompanioni theborakompanioni marked this pull request as ready for review September 19, 2023 12:14
Copy link
Member

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK af9f462

@kristapsk
Copy link
Member

Merging, this seems like an obvious bugfix.

image

@kristapsk kristapsk merged commit 84aef85 into JoinMarket-Org:master Sep 20, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: duplicate mapping key in wallet-rpc.yml
2 participants