New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test that assumes mempoolfullrbf=0 #1737

Merged

kristapsk merged 1 commit into JoinMarket-Org:master from kristapsk:rm-test_check_valid_candidate_not_replaceable

Oct 23, 2024

Member

kristapsk commented Oct 23, 2024 •

edited

Loading

It has never been safe to assume that an unconfirmed transaction could not be replaced.

#1734 (comment)

Resolves #1734.


          Remove test that assumes mempoolfullrbf=0

669839e

It has never been safe to assume that an unconfirmed transaction could not be replaced.

kristapsk added the Testing label

Member Author

kristapsk commented Oct 23, 2024

Merging this without reviews, as it's obvious. We already support mempoolfullrbf=1 replacements in scripts/bumpfee.py.

kristapsk merged commit d7050f1 into JoinMarket-Org:master

11 checks passed

kristapsk deleted the rm-test_check_valid_candidate_not_replaceable branch

October 23, 2024 09:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels