Import, syncing improvement #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, there was duplicated code in maker and taker modules to import addresses, now all calls to the wallet for fresh addresses can optionally pass a blockchaininterface instance and if this is done, the new address will be imported to the BCI at the same time.
Prior to this commit, addresses imported on tx creation were at the tip of the index only, but detailed sync requires all address gap-forwards to be imported, else it requires a restart. The particular fix approach taken her is aggression because import is cheap; we import wallet.gaplimit forwards on all branches, taking advantage of the bci's function _collect_addresses_gap, thus ensuring that unless the gap limit changes, we will definitely not need a restart. Fast sync did not suffer from this and is unchanged.
AdamISZ
added a commit
that referenced
this pull request
Aug 17, 2019
4b4f8c9 Fix bug in detailed wallet sync relating to gap addrs. (AdamISZ) 6c15bd7 Make address imports with address requests in wallet Prior to this commit, there was duplicated code in maker and taker modules to import addresses, now all calls to the wallet for fresh addresses can optionally pass a blockchaininterface instance and if this is done, the new address will be imported to the BCI at the same time. (AdamISZ)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits were detailed in #359 but since that project is incomplete and these changes were found, after considerable testing by myself and @kristapsk , to be useful for improving the wallet syncing experience, and since we want to push out a release, they are being PR-ed and then merged here separately from that.