Add dialog for displaying seed phrase to JM-Qt #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, I'd totally forgot we didn't have that. Thanks! |
|
The travis build seemed to have failed because it stalled, not anything to do with the PR code. |
kristapsk
reviewed
Oct 17, 2019
chris-belcher
force-pushed
the
create-show-seed-dialog
branch
from
008bb89 to
815b8a3
Compare
chris-belcher
force-pushed
the
create-show-seed-dialog
branch
from
815b8a3 to
9dee0d7
Compare
|
Fixed after #359, tested myself. |
chris-belcher
added a commit
that referenced
this pull request
Oct 25, 2019
9dee0d7 Add dialog for displaying seed phrase to JM-Qt (chris-belcher) Tree-SHA512: fa8b30c8078f85e9c877d23cff426fe031b74c2adff22609b59c0642ebfb7779986fbb7142906a707a4d1458db08823691d226ee80ca3154cc2cb04da89a86fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the Joinmarket-Qt application didn't have a way to display the seed phrase of a loaded wallet. This seemed like an oversight.
Also I made the display words dialog use bold font for the words and extension.
Also I rearranged some of the QAction lines so they match the order that the options appear in the GUI.
I've tested with and without an extension.