Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to TODO.md #474

Merged
merged 1 commit into from
Dec 23, 2019
Merged

updates to TODO.md #474

merged 1 commit into from
Dec 23, 2019

Conversation

AdamISZ
Copy link
Member

@AdamISZ AdamISZ commented Dec 19, 2019

Basically rewrote the "joinmarket protocol" (mentioning future possible bech32 upgrade, possible adding of fidelity bonds, probably could add more stuff, not sure) and the "bitcoin" part (we basically reached a point where it's clear we need a rewrite as per that paragraph, the old paragraph isn't really relevant any more). mostly left the rest untouched (because, unfortunately, most of those issues are still outstanding).

If people disagree with these points let me know, if on the other hand you want to add more stuff to this document (and I understand maybe some people think it's a pointless document to have, but I kinda disagree), then maybe add another PR afterwards.

docs/TODO.md Outdated
Possible future update ("hard fork") for Joinmarket protocol may include:
* bech32 addresses for joins; possibly mixed address types, needs discussion.
* change format of data transfer (in particular, avoid double encoding which wastes space)
* w.r.t above issue693, see fidelity bonds [discussion](https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-August/017204.html) ; if implemented this may (will?) require some changes to protocol messages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not so important, but w.r.t. was an abbreviation I needed google for as a non-native English speaker... :)

Also, maybe adding link to #371 here would not hurt.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for the feedback, and I'll use that link instead of the mailing list one

@AdamISZ
Copy link
Member Author

AdamISZ commented Dec 20, 2019

@undeath I can also add a reference to your Issue re decentralized architecture proposal to that section.

@AdamISZ
Copy link
Member Author

AdamISZ commented Dec 21, 2019

Changes as per discussion and a bit more added, I'll merge in a couple of days if no further comments.

@chris-belcher
Copy link
Contributor

Fidelity bonds dont just deal with issue 693, they also deal with sybil attacks (which don't have an issue number assigned but have been known about since joinmarket was first proposed)

@AdamISZ
Copy link
Member Author

AdamISZ commented Dec 21, 2019

I don't get it; isn't issue 693 (as per JoinMarket-Org/joinmarket#693 ) a Sybil attack problem? Many makers one wallet?

@chris-belcher
Copy link
Contributor

Someone could also do a sybil attack without using 693. The issue 693 makes a sybil attack a bit cheaper, but solving it doesn't solve sybil attacks.

@AdamISZ
Copy link
Member Author

AdamISZ commented Dec 23, 2019

Added an extra comment about end to end testing, merging now. Feel free to suggest other changes to this.

AdamISZ added a commit that referenced this pull request Dec 23, 2019
0d31f31 updates to TODO.md (Adam Gibson)
@AdamISZ AdamISZ merged commit 0d31f31 into master Dec 23, 2019
@AdamISZ AdamISZ deleted the update_todo branch December 23, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants