Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Only show wallet sync in status bar at start #481

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Conversation

AdamISZ
Copy link
Member

@AdamISZ AdamISZ commented Jan 3, 2020

In refactor for #359 it was noted that the wallet
monitoring loop in Qt updated the status bar every
5 seconds, overwriting any existing status updates.
This fixes that UI bug so that the wallet synced
successfully (or unsucessfully) message is only shown
at start up or if there is a change of status (i.e.
the wallet monitoring loop stops working).

In refactor for #359 it was noted that the wallet
monitoring loop in Qt updated the status bar every
5 seconds, overwriting any existing status updates.
This fixes that UI bug so that the wallet synced
successfully (or unsucessfully) message is only shown
at start up or if there is a change of status (i.e.
the wallet monitoring loop stops working).
Copy link
Member

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ce49ea3 (tested that main menu hints on statusbar does not get replaced with "Wallet synced successfuly." if hovering mouse over it for a few seconds)

AdamISZ added a commit that referenced this pull request Jan 4, 2020
ce49ea3 Qt: Only show wallet sync in status bar at start (Adam Gibson)
@AdamISZ AdamISZ merged commit ce49ea3 into master Jan 4, 2020
@AdamISZ AdamISZ deleted the qt-statusmsg-fix branch January 4, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants