Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decompile): safe array access when building abi #492

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

Jon-Becker
Copy link
Owner

Motivation

Solution

@Jon-Becker Jon-Becker linked an issue Sep 2, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Benchmark for 391313c

Click to view benchmark
Test Base PR %
heimdall_cfg/complex 14.6±0.07ms 14.0±0.32ms -4.11%
heimdall_cfg/simple 2.2±0.01ms 2.2±0.01ms 0.00%
heimdall_decoder/seaport 40.2±2.29µs 39.6±2.32µs -1.49%
heimdall_decoder/transfer 2.9±0.23µs 2.6±0.09µs -10.34%
heimdall_decoder/uniswap 10.8±0.52µs 10.2±0.60µs -5.56%
heimdall_decompiler/abi_complex 61.3±0.79ms 58.4±2.27ms -4.73%
heimdall_decompiler/abi_simple 2.2±0.03ms 2.2±0.01ms 0.00%
heimdall_decompiler/sol_complex 71.7±0.55ms 70.0±1.17ms -2.37%
heimdall_decompiler/sol_simple 2.6±0.01ms 2.5±0.01ms -3.85%
heimdall_decompiler/yul_complex 64.6±1.47ms 62.5±2.14ms -3.25%
heimdall_decompiler/yul_simple 2.3±0.10ms 2.3±0.08ms 0.00%
heimdall_disassembler/complex 980.4±33.88µs 936.1±34.76µs -4.52%
heimdall_disassembler/simple 47.5±2.90µs 44.6±4.11µs -6.11%
heimdall_vm/erc20_transfer 342.6±13.83µs 353.8±35.87µs +3.27%
heimdall_vm/fib 906.3±39.91µs 845.6±52.66µs -6.70%
heimdall_vm/ten_thousand_hashes 5.1±0.16s 4.9±0.09s -3.92%

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Benchmark for 90b5223

Click to view benchmark
Test Base PR %
heimdall_cfg/complex 15.6±1.64ms 13.7±1.01ms -12.18%
heimdall_cfg/simple 2.1±0.02ms 2.0±0.13ms -4.76%
heimdall_decoder/seaport 32.5±2.00µs 32.4±1.38µs -0.31%
heimdall_decoder/transfer 3.8±0.23µs 3.6±0.23µs -5.26%
heimdall_decoder/uniswap 9.9±0.60µs 9.5±0.45µs -4.04%
heimdall_decompiler/abi_complex 55.8±4.10ms 54.1±3.23ms -3.05%
heimdall_decompiler/abi_simple 2.1±0.04ms 1945.3±15.75µs -7.37%
heimdall_decompiler/sol_complex 60.1±1.58ms 63.7±1.06ms +5.99%
heimdall_decompiler/sol_simple 2.4±0.01ms 2.3±0.03ms -4.17%
heimdall_decompiler/yul_complex 53.4±1.67ms 56.4±3.29ms +5.62%
heimdall_decompiler/yul_simple 2.2±0.01ms 2.2±0.04ms 0.00%
heimdall_disassembler/complex 798.4±28.63µs 806.6±28.21µs +1.03%
heimdall_disassembler/simple 39.9±3.17µs 41.0±1.61µs +2.76%
heimdall_vm/erc20_transfer 297.5±13.84µs 289.8±10.58µs -2.59%
heimdall_vm/fib 767.0±12.00µs 710.4±14.37µs -7.38%
heimdall_vm/ten_thousand_hashes 552.6±39.21ms 553.9±36.44ms +0.24%

@Jon-Becker Jon-Becker merged commit 6649fb2 into main Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: index out of bounds: the len is 1 but the index is 1
1 participant