Fix: hiding other folders on scroll #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoxmb
force-pushed
the
fix/hiding-other-folders-on-scroll
branch
from
8fb0da2
to
423576a
Compare
joaoxmb
force-pushed
the
fix/hiding-other-folders-on-scroll
branch
from
423576a
to
8c0ba92
Compare
|
Hey, that's great. Thanks so much for your contribution! :) I will test it and if everything seems ok release a update with your PR later this day 👍 |
…ad of overwriting everythng
|
Just a small change I pushed: instead of setting the whole |
|
Released in v1.2.1 🥳 |
|
I'm very happy to be able to contribute to something that really makes a difference to me. Now I can continue using it without any problems 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the hiding of other folders unrelated to the one configured to be removed by the plugin, see the bug and the solution I took for it in this video
This bug is related to the styling applied to hide the folder in the DOM, specifically in the
display: none;tag applied to hide it. The solution to this problem was to changedisplay: none;toheight: 0;overflow: hidden;.