-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ready for use RRule instance with caching #20
Conversation
I do not know how to cache |
I'm inspired by this repository https://github.com/jakubroztocil/rrule |
Thanks for this contribution! Caching seems like a really useful feature as the internal calculations in this package can get quite complex. I have a few questions/comments/suggestions about the architecture of this caching:
|
This can reduce the cold start. If I have 1000 recurring tasks, it will be better to use cached values rather than calculated ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I've added some minor comments, and then this can get merged :)
(You can ignore the failing lint actions.)
Co-authored-by: Jonas Wanke <contact@wanke.dev>
Co-authored-by: Jonas Wanke <contact@wanke.dev>
Co-authored-by: Jonas Wanke <contact@wanke.dev>
This is now published as part of v0.2.3. Thanks for contributing! |
Add RRule ready for use instance with result caching
Checklist