Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy microseconds in DateTime #49

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

plammens
Copy link
Contributor

Closes: #48

Sorry I didn't notice this too. I saw you did notice it and added a comment about web not supporting microseconds, but it's OK to pass microseconds, when running on the web the SDK will just ignore them, I've tested it. Like this the issue is fixed on all other platforms too.

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Copy link
Owner

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original intention was to have the same behavior on both platforms (web and VM), but I guess it doesn't make sense to artificially restrict code running outside the browser just because of that

lib/src/utils.dart Outdated Show resolved Hide resolved
lib/src/utils.dart Outdated Show resolved Hide resolved
Closes JonasWanke#48

style: Fix bad rebase

Co-authored-by: Jonas Wanke <contact@wanke.dev>
@plammens plammens force-pushed the fix/microseconds-2 branch from 3012a98 to cd338ed Compare March 21, 2023 17:26
@JonasWanke JonasWanke merged commit 772902c into JonasWanke:main Mar 22, 2023
@JonasWanke
Copy link
Owner

Thanks for your contribution! This is published as v0.2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microseconds are removed from start time
2 participants