fix(iteration): prevent IntegerDivisionByZeroException with SETPOS #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #44
The problem is, if you go by month, it iterates over every day of every month, starting with January. In the provided example, no day of year in January (1-31) matches any date in the dateset, therefore
dateIndices
is empty and it throws aIntegerDivisionByZeroException
when usingdateIndices.length
on the right hand side of the modulo operator inset_positions_list.dart
.rrule/lib/src/iteration/set_positions_list.dart
Line 33 in f557fe9
This PR fixes the problem by just moving on.