feat: Multiple language support and 24-hour format support #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasWanke
requested changes
Jun 19, 2021
|
@JonasWanke Hi, Thanks for the review :) I pushed the fixes on 7ee1a28, could you check it please? |
JonasWanke
approved these changes
Jun 19, 2021
|
Thanks :) I'll let you know when I publish this to pub.dev, which I'll hopefully get around to in the next few days (after fixing a few things) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #61
This change will fix an issue: user cannot remove the created time overlay if drag gesture canceled without any movement.
Checklist