Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Spanish localization #84

Merged
merged 4 commits into from
Jul 15, 2021
Merged

feat: Add Spanish localization #84

merged 4 commits into from
Jul 15, 2021

Conversation

paolovalerdi
Copy link
Contributor

No description provided.

JonasWanke
JonasWanke requested changes Jul 15, 2021
View reviewed changes
Copy link
Owner

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It looks like there's one small typo, but after that is fixed, I'm happy to merge this PR

lib/src/localization.dart Outdated Show resolved Hide resolved
@paolovalerdi
Copy link
Contributor Author

Oops 😅, I didn't realize, it's fixed, now and I also add it to the supported locales in the example app

@JonasWanke JonasWanke merged commit 2c3b951 into JonasWanke:main Jul 15, 2021
@JonasWanke
Copy link
Owner

Thanks for the quick fix :) I'll try to release it soon!

@JonasWanke
Copy link
Owner

Sorry for the delay! This is now published as part of v1.0.0-alpha.3. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasWanke JonasWanke JonasWanke requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolovalerdi @JonasWanke