Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding languages- French and Portuguese #94

Merged
merged 2 commits into from
Aug 7, 2021
Merged

Adding languages- French and Portuguese #94

merged 2 commits into from
Aug 7, 2021

Conversation

simo9900
Copy link

@simo9900 simo9900 commented Aug 6, 2021

Closes: #Issue

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@simo9900
Copy link
Author

simo9900 commented Aug 6, 2021

Adding languages- French and Portuguese

JonasWanke
JonasWanke requested changes Aug 7, 2021
View reviewed changes
Copy link
Owner

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've added two minor comments; when these are fixed, I'm happy to merge this PR

lib/src/localization.dart Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@JonasWanke JonasWanke merged commit 97b9737 into JonasWanke:main Aug 7, 2021
@JonasWanke
Copy link
Owner

This is now published as part of v1.0.0-alpha.5. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasWanke JonasWanke JonasWanke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simo9900 @JonasWanke