Big modification of the global structure. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal was too delete some useless dependences to Triton.h and pin.H. The other key idea is too lighten Triton.h, it should contain only the necessary include and definition/declaration useful in core.cpp. How do we achieve these goals ? For pin.H, it's pretty simple most of the types define by pin.H (UINT64, ADDRINT, ...) are here only for handle Microsoft and Unix platforms. Right now, we focus only on Unix so we just need to use define in stdint.h (uint64_h). For Triton.h, it's trickier but the solution is ,the most often, to define some headers or tweak the existing one. And then include this "new" header in Triton.h.
JonathanSalwan
added a commit
that referenced
this pull request
Jan 27, 2015
Big modification of the global structure.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal was too delete some useless dependences to Triton.h
and pin.H.
The other key idea is too lighten Triton.h, it should contain
only the necessary include and definition/declaration useful in
core.cpp.
How do we achieve these goals ?
For pin.H, it's pretty simple most of the types define by pin.H (UINT64,
ADDRINT, ...) are here only for handle Microsoft and Unix platforms.
Right now, we focus only on Unix so we just need to use define in
stdint.h (uint64_h).
For Triton.h, it's trickier but the solution is ,the most often, to
define some headers or tweak the existing one. And then include this
"new" header in Triton.h.