Don't run the entrypoint for each line in a multi-line script #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonReinhart
changed the title
JonathonReinhart
force-pushed
the
114-fix-entrypoint-semantics
branch
2 times, most recently
from
a0f1964
to
09ebaf0
Compare
**This is a breaking change.** The previous logic was generally incorrect. For a multi-line script, Scuba would prepend each line with the entrypoint. This sort of makes sense, except the script is run within *one* `docker run` invocation. Many image entrypoints are wrappers which set up things in the container, and then execute the user command which is passed as arguments to the entrypoint (e.g. `exec "@"`). Thus, it isn't right to execute the entrypoint multiple times in the same container. This changes the behavior of Scuba to instead invoke the entrypoint, passing it the path of the scuba-generated script to be executed. In this way, the entrypoint is only run once. N.B. This means that Scuba no longer works with images which wrap a single command (e.g. an "application" image which sets some CLI application as the entrypoint). If this use case is needed in the future, an additional YAML option (e.g. `entrypoint_each_line`) could be added to restore the old behavior. Fixes #114
JonathonReinhart
force-pushed
the
114-fix-entrypoint-semantics
branch
from
09ebaf0
to
1b521ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.It was decided that this is not a breaking change. This installs the originally-intended behavior. If someone really wants the old behavior, please open an issue and we can add a flag that does so.Fixes #114