Inject /etc/passwd and friends instead of .scubainit #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid the fact that .scubainit uses `su -c` to run the user command as scubauser, but now it is no longer PID 1. This fixes #22.
This adds a proper /etc/shadow entry as well, fixing the "Authentication error\n(ignored)" from su. This fixes #21.
- `shell_quote` was only used for generating .scubainit - `get_image_command` was only needed because we were launching .scubainit instead of the usercmd - `get_umask` was used to set the umask in .scubainit, which is unfortunately not possible now
This was referenced Jan 8, 2016
JonathonReinhart
added a commit
that referenced
this pull request
Jan 8, 2016
Inject /etc/passwd and friends instead of .scubainit
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of injecting
.scubainitand starting the container with/bin/sh /.scubainit, this will:/etc/passwd,/etc/group, and/etc/shadowfiles withscubauseraddedThis fixes #21 and #22.
The unfortunate part of this fix is that it removes the setting of
umask, introduced in v1.3.0 by #16, because we no longer have a.scubainit.