Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staticx: Use importlib.resources over pkg_resources for asset access #274

Merged
merged 1 commit into from
Jan 14, 2024

Commits on Jan 14, 2024

  1. staticx: Use importlib.resources over pkg_resources for asset access

    pkg_resources is deprecated:
    https://setuptools.pypa.io/en/latest/pkg_resources.html
    
    This instead uses importlib.resources.files() (introduced in Python 3.9)
    and uses the backport importlib_resources for Python 3.7-3.8 (to be
    removed in #264, #265).
    
    This was chosen over the alternative of using the deprecated (as of
    Python 3.11) function importlib.resources.open_binary() (introduced in
    Python 3.7), since we already have techdebt to remove a related
    backport, which is preferable to upgrading from the deprecated API.
    JonathonReinhart committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    81fa8fe View commit details
    Browse the repository at this point in the history