Combine insert calls into bundles to reduce archetype count
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the "cubes" example, archetype count went from 65 to 29.
RJ
pushed a commit
to RJ/avian
that referenced
this pull request
Sep 25, 2023
…f#151) Removes individual `insert` calls in `prepare.rs` in favor of single calls that add multiple components at once. This reduces the archetype count significantly. For a `MinimalPlugins` setup with just meshless cuboid rigid bodies, the archetype count went from 26 to 5. It could probably still be reduced by a few archetypes, but it would maybe hurt code quality/modularity a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes individual
insertcalls inprepare.rsin favor of single calls that add multiple components at once. This reduces the archetype count significantly.For a MinimalPlugins setup with just cuboid rigid bodies, the archetype count went from 26 to 5. It could probably still be reduced by a few archetypes, but it would maybe hurt code quality/modularity a bit.