Take child collider rotation into account for contact normals #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently, local contact normals are only rotated by the rotation of each body, but the rotation of child colliders is not taken into account. This causes collision stability issues and incorrect behavior when child colliders are rotated.
For example, with the code below, the cube falls through the ground as reported by
@mbreac
on the Bevy Discord:Solution
Rotate the contact normals passed to the solver by the rotation of the participating child collider. This fixes the issues.