fix: make clear_forces_and_impulses public
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
reviewed
Nov 29, 2023
Jondolf
reviewed
Nov 29, 2023
Jondolf
reviewed
Nov 29, 2023
Jondolf
reviewed
Nov 29, 2023
to remove double line break Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
To add trailing newline Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
To improve documentation Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
|
OK I believe all changes are in order |
Jondolf
reviewed
Nov 30, 2023
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I am wanting to implement custom logic that runs just after
ExternalForceis cleared. This helps solve issue #256.Solution
Make the function
clear_forces_and_impulsespublic, so that other external systems can order against it. In my case, I want to order.after(clear_forces_and_impulses).Changelog
Changed
The function
clear_forces_and_impulses was make public