Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply scale in Collider::set_shape #278

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Apply scale in Collider::set_shape #278

merged 1 commit into from
Dec 15, 2023

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Dec 15, 2023

Objective

Collider::set_shape only updates the unscaled version of the collider. The scaled version incorrectly remains unchanged.

Solution

Update the scaled version as well.

@Jondolf Jondolf added bugfix A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality labels Dec 15, 2023
@Jondolf Jondolf merged commit 58d3f97 into main Dec 15, 2023
4 checks passed
@Jondolf Jondolf deleted the fix-set-shape-scale branch December 15, 2023 23:05
@Jondolf Jondolf mentioned this pull request Jan 16, 2024
Closed
@Jondolf Jondolf added C-Bug Something isn't working and removed bugfix labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality C-Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jondolf