Fix Time
inconsistency after substepping loop
#294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
There are currently two issues that cause
Time
to be inconsistent, even with a fixed timestep:Time
resource is always set toTime<Virtual>
. However, thePhysicsSchedule
is still running. This means that systems running after substeps but before the end of the physics schedule will have a variableTime
.PhysicsSchedule
,Time
is set toTime<Virtual>
. This means that if physics is run inFixedUpdate
, the fixed timestep will be overwritten byTime<Virtual>
.Solution
Time
toTime<Physics>
instead. The physics schedule will later set it to the default clock.Time
to the clock that was used before thePhysicsSchedule
.