fix raycast does not follow entity transform without rigidbody #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwazel
changed the title
|
Hi, sorry for leaving this sit here for so long! It seems to work though, thanks :) I cleaned up the code a bit to remove the temp variables and make things more concise, and fixed some lint warnings that Clippy was giving |
Jondolf
added
bugfix
A-Spatial-Query
brianreavis
pushed a commit
to naturalatlas/bevy_xpbd
that referenced
this pull request
Feb 17, 2024
…lf#310) # Objective - Fixes Jondolf#288 ## Solution - If no Rotation and Position is available, fall back to GlobalTransform ## Changelog - I've added a `From<GlobalTransform>` and `From<&GlobalTransform>` to `Position` as well as a `From<&GlobalTransform>` to `Rotation`. as a `From<GlobalTransform>` already existed. I tested the updated `update_ray_caster_positions` system in my personal project, and it fixed the problem for me. I currently can't test the `update_shape_caster_positions` but as it is basically the same changes, i'd be surprised if it wouldn't work. as this is my first time contributing to this crate, i'm not sure if the code is what is expected. --------- Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Changelog
From<GlobalTransform>andFrom<&GlobalTransform>toPositionas well as aFrom<&GlobalTransform>toRotation. as aFrom<GlobalTransform>already existed.I tested the updated
update_ray_caster_positionssystem in my personal project, and it fixed the problem for me. I currently can't test theupdate_shape_caster_positionsbut as it is basically the same changes, i'd be surprised if it wouldn't work.as this is my first time contributing to this crate, i'm not sure if the code is what is expected.