Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage without Parry #477

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Fix usage without Parry #477

merged 2 commits into from
Aug 3, 2024

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Aug 3, 2024

Objective

Avian caused a regression from bevy_xpbd that makes the engine require parry-f32 or parry-f64. Avian should be usable without Parry.

Solution

  • Add our own PackedFeatureId type (API matches Parry to avoid breaking changes for now)
  • Put collider constructor logic behind default-collider feature flags
  • Put swept CCD systems behind parry-f32/parry-f64
    • We could maybe traitify this and make swept CCD work for custom colliders, but currently it has some logic that depends heavily on Parry shapes, so for now it is just disabled without Parry.

@Jondolf Jondolf added C-Regression Behaviour that was working before is now worse or broken A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality P-Compile-Failure A failure to compile Avian labels Aug 3, 2024
@Jondolf Jondolf merged commit e2a1695 into main Aug 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality C-Regression Behaviour that was working before is now worse or broken P-Compile-Failure A failure to compile Avian
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jondolf