Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only warn about 'overlapping at spawn' for dynamic bodies #491

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

RJ
Copy link
Contributor

@RJ RJ commented Aug 16, 2024

Objective

When spawning lots of overlapping static colliders (eg: walls) i see a lot of "X and Y are overlapping at spawn, which can result in explosive behavior".

Explosive behaviour is only a concern for dynamic bodies.

Solution

Only show the warning if at least one of the bodies is dynamic.


Changelog

  • "Overlapping at spawn" warning now only applies if at least one of rigid bodies is dynamic

@RJ
Copy link
Contributor Author

RJ commented Aug 22, 2024

can't reproduce my issue with the warning appearing re: static rigidbodies. i definitely was plagued with loads of warnings about my static walls at some point, but it's possible i'd configured something wrong.

i think it's still a worthwhile patch to prevent warnings when kinematic bodies overlap though

@Jondolf Jondolf added the A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality label Aug 22, 2024
@Jondolf Jondolf merged commit 571dcc6 into Jondolf:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants