Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing feature flag #502

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix missing feature flag #502

merged 2 commits into from
Aug 28, 2024

Conversation

janhohenheim
Copy link
Sponsor Contributor

Objective

While depending on Avian's main branch, running cargo doc --all-features fails on my crate when including a serialize feature

Solution

Fix bitflags not being serializable when serializing. Ideally, the CI should catch this.

@janhohenheim janhohenheim changed the title Fix missing features flag Fix missing feature flag Aug 27, 2024
@Jondolf Jondolf added the C-Bug Something isn't working label Aug 28, 2024
@Jondolf Jondolf merged commit f1a98d9 into Jondolf:main Aug 28, 2024
4 checks passed
@janhohenheim janhohenheim deleted the patch-1 branch September 8, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jondolf Jondolf Jondolf approved these changes

Assignees
No one assigned
Labels
C-Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janhohenheim @Jondolf