-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow interpolation of scales #512
Allow interpolation of scales #512
Conversation
@Jondolf could you help me out with the CI failure? With the |
It most likely is; |
Yep, you were right :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Objective
For
avian_interpolation
, I want to have a clean separation between gameplay transforms and render transforms. Avian's best version of a gameplay scale is currentlyCollider::scale
. However, this is not ergonomically interpolatable due to two reasons:Collider::scale
is not initialized with the right scale, meaning that my observers that listen for its insertion will read wrong initial data, andGlobalTransform
, making it hard to change theTransform
according to theCollider::scale
without affecting it back in turnRelated to #444
Solution
Collider::scale
correctly in itson_add
hookSyncConfig
Changelog
Transform
toCollider::scale
syncing by using the newSyncConfig::transform_to_collider_scale
field.