Config test #21
Merged
Config test #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspic
commented
Dec 16, 2020
src/server/test/proxy_file.test.js
Outdated
|
|
||
| test('log proxy settings with default config from file', () => { | ||
| let settings = [] | ||
| fs.copyFileSync('settings.json.default', settingsPath, ) |
There was a problem hiding this comment.
This overwrites any changes to a potential "local" settings.json file. However, these test should never be run in an environment.
aspic
commented
Dec 16, 2020
| @@ -1,5 +1,7 @@ | |||
| require('dotenv').config() // load variables from .env into the environment | |||
| require('console-stamp')(console) | |||
| const test_override_http = !process.env.OVERRIDE_USE_HTTP | |||
There was a problem hiding this comment.
Had to have some way of overwriting the use_http variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to log most configuration logging to an array, and use that to verify that typescript refactor (#20) is successful.