Typescript process request #38

aspic · 2021-01-03T07:53:47Z

Splits up and adds types for the process request function.

Explicitly returns responses which seems to have been the original intention.
Refactors so that all "token responses" are handled by their own function (makes it easier to test down the road)
Moves some generic functions into tools.ts
Moves from prop in obj check to obj.prop check
Renames Error to NodeRPCError due to Error clashing with the built inn Error-type

src/server/src/proxy.ts

src/server/src/node-api/proxy-api.ts

aspic commented Jan 3, 2021

View reviewed changes

src/server/src/proxy.ts Outdated Show resolved Hide resolved

Joohansson reviewed Jan 3, 2021

View reviewed changes

src/server/src/node-api/proxy-api.ts Outdated Show resolved Hide resolved

aspic added 11 commits January 3, 2021 16:31

Adds base types

a29cb17

More fields

33e3b4b

Forces return statement

fb2f7ad

Renames to TokenAPIError

6b93566

Removes redundant class

0ed4a09

Adds token api types

ecda089

Moves proxy specific things to proxy-api

58c37ff

Moves some functions to tools

db934f1

Moves guard to if statement

d7fe773

Renames error type

8bb3c61

Moves to proxy-api

e773970

aspic force-pushed the typescript-process-request branch from ba23d5b to e773970 Compare January 3, 2021 15:32

aspic added 8 commits January 3, 2021 16:39

Adds test for multiplier/Dec dependency

7665c7d

API gives 500

a2eeebd

Adds log line

3cfc53d

Wrong type

a071fe0

Part of responses

3f64048

Renames

ed7986f

Changes name of Error

698adcb

Changes name

3d4e1c0

Joohansson merged commit 1c24449 into Joohansson:master Jan 3, 2021

Provide feedback