-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds proposal for Prometheus metrics #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sounds interesting! I guess you also have to add the extra setting to settings.json.default? |
Joohansson
approved these changes
Jan 23, 2021
Updated PR with these changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #46, adds initial support of Prometheus metrics. These metrics must then either be pushed, or as in this case be scraped from the endpoint
/prometheus
. This PR is merely to show what is possible, and only exposes a few of the metrics.One must-fix if we decide to progress with this is to ensure
/prometheus
endpoint is "protected" somehow (at least if exposing anything like IP adresses).A method of testing this can be to add this to the docker-compose-file (the proxy exposes metrics → prometheus scrapes metrics → grafana displays metrics):
And make the
prometheus.yml
point to the Nano RPC proxy prometheus endpoint like this:When setting up
Prometheus
as datasource in Grafana, you would then get live metrics like this: