Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure #75

Merged
merged 6 commits into from
Feb 11, 2021
Merged

Restructure #75

merged 6 commits into from
Feb 11, 2021

Conversation

aspic
Copy link
Collaborator

@aspic aspic commented Feb 10, 2021

Updates to a more idiomatic javascript structure, closes #74.

There will be breaking changes in this PR, for folks have installed as "service using PM2". Then the system files needs to be updated to point to ./dist/ instead of src/server/dist [0]

Docker container should behave exactly as before, but we build the image a bit differently.

Also updated github workflows. Almost certain the docker build/push should work, but you never know with this stuff 🤷‍♂️

[0] - master...restructure#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L130

@aspic aspic added the enhancement New feature or request label Feb 10, 2021
@aspic aspic requested a review from Joohansson February 10, 2021 15:26
@Joohansson Joohansson merged commit b34a26b into master Feb 11, 2021
@Joohansson Joohansson deleted the restructure branch February 11, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to idiomatic javascript project structure
2 participants