-
Notifications
You must be signed in to change notification settings - Fork 9
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier method for scripture Input #147
Comments
Great idea, Eugen. I originally modeled the Scripture entry on SermonCentral.com. |
We still cold us the tables as is but just do some JS to fill in the right On Tue, Apr 9, 2013 at 9:52 AM, tomfuller2 notifications@github.com wrote:
Thanks, |
@bcordis The filters by default, I believe, work only on column values, so for filtering by a specific book under this method is a little bit more complex. If we implement this in a utility class (or library?), then the burden would be on this utility class of providing proper methods for handling filtering, localization, and other required functionality. |
@genu |
I didn't look how the contacts component works. We could, as a first step in this direction, take that route and just map a string of scripture references to those table columns. However, we will still be limited by only 2 scripture references per message. correct? |
unless we redo the db and do it in a JSON string in one column. On Tue, Apr 9, 2013 at 11:06 AM, Eugen Istoc notifications@git.luolix.topwrote:
Thanks, |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
For the longest time, the scripture has been inputed as: book, chapter_begin, verse_begin, verse_end, chapter_end, book2, chapter_begin2 etc.
A good improvement to this, is to allow the user to enter scripture references directly like so:
John 3:16, Romans 1:16
I'm thinking this could be implemented as a single text field with autocomplete, so that only correct scripture references are acceptable.
A utility class will need to be created to validate a given input to test whether its a valid scripture or not. (i.e.
John 3:16
would be valid, whilejohn 0:16
would be invalid). The user is alerted whether a references they entered is valid or not as they're entering it. Multiple references are simply separated by a comma.Taking this approach, will allow us to truncate more than 10 columns in the message database.
Related Tasks
The text was updated successfully, but these errors were encountered: