Add ultranest sampler (Sourcery refactored) #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.26%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
sourcery-ai
bot
force-pushed
the
sourcery/ultranest
branch
from
2c2cb13
to
3139dda
Compare
| if log_mass is None: | ||
| return -1 | ||
| return round(np.power(10, log_mass), 3) | ||
| return -1 if log_mass is None else round(np.power(10, log_mass), 3) |
There was a problem hiding this comment.
Function DDDMResult.mass refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-110
to
+108
| if param is None: | ||
| return None | ||
|
|
||
| return len(param) | ||
| return None if param is None else len(param) |
There was a problem hiding this comment.
Function DDDMResult.n_parameters refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-266
to
+261
| if x <= 1: | ||
| return f'${x:.1f}$' | ||
| return f'${int(x)}$' | ||
| return f'${x:.1f}$' if x <= 1 else f'${int(x)}$' |
There was a problem hiding this comment.
Function set_xticks_top refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-51
to
+53
| with open(save_as + 'config.json', 'w') as file: | ||
| with open(f'{save_as}config.json', 'w') as file: | ||
| json.dump(convert_dic_to_savable(c.config), file, indent=4) | ||
| np.save(save_as + 'config.npy', convert_dic_to_savable(c.config)) | ||
| np.save(f'{save_as}config.npy', convert_dic_to_savable(c.config)) |
There was a problem hiding this comment.
Function _CombinedInference.save_sub_configs refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
| warnings.warn(f'Ultranest sampler is not completely implemented yet') | ||
| warnings.warn('Ultranest sampler is not completely implemented yet') |
There was a problem hiding this comment.
Function UltraNestSampler.run refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-23
to
+34
| config = {**base_config, **kwargs} | ||
| config = base_config | kwargs | ||
| sampler = self.ct.get_sampler_for_detector(**config) | ||
|
|
||
| results, _ = sampler.run() | ||
|
|
||
| fails = [] | ||
| for i, (thing, expected, avg, std) in enumerate( | ||
| zip( | ||
| for thing, expected, avg, std in zip( | ||
| base_config.get('fit_parameters'), | ||
| [getattr(sampler, f) for f in base_config.get('fit_parameters')], | ||
| results['posterior']['mean'], | ||
| results['posterior']['stdev'] | ||
| )): | ||
| ): |
There was a problem hiding this comment.
Function PymultinestTest.test refactored with the following changes:
- Applies the dictionary union operator where applicable (
use-dictionary-union) - Remove unnecessary calls to
enumeratewhen the index is not used (remove-unused-enumerate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #246 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
ultranestbranch, then run:Help us improve this pull request!