Test Cases #4

anilhelvaci · 2024-01-19T07:38:02Z

To begin with

Liquidation: No shortfall
- Insert our assertions in this test test vault liquidation @alexanderem49
Liquidation: Collateral sold debt not covered
- Base test for this scenario shortfall @anilhelvaci
Liquidation: Unsold collateral
- Base test for this one reinstate vault

anilhelvaci · 2024-01-19T07:52:11Z

Generic assertions

Check that no child node with auction start time's name created before the liquidation
Check that {timestamp}.vaults.preAuction values are correct before auction is completed
Check that {timestamp}.vaults.postAuction values are correct after auction is completed
Check that {timestamp}.auctionResult values are correct after auction is completed
Create snapshot of the storage node => documentStorageSchema

…om the vstorage

…rtions for running the tests

…updated, #7 is fixed

Jorge-Lopes · 2024-01-29T17:22:11Z

Test coverage (unit test)

Done:

liquidation flow 1
liquidation flow 2a
liquidation flow 2b

ToDo:

no vaults are liquidated
force a promise rejection in:
- E(auctionPF).getSchedules()
- helper.makeLiquidationRecorderKits(timestamp)
force an error while distributing proceeds
assert that vaultId being recorded under liquidations correspond to the correct vaultId under vaults
test flow with more than one vaultManager
- same collateral
- different collateral

Side Tasks:

update tests names with something more descriptive.
the same for comments describing the tests

cc: @alexanderem49

…tupBasics

… schedule

…pdate file name

…e test

Jorge-Lopes · 2024-02-01T18:24:17Z

ToDo:

Assure that all tests follow the same logic in its assertions
- See flow 1 vs flow 2a and 2b
Clean "ToDo" comments

Jorge-Lopes · 2024-02-02T17:01:33Z

Unit test: multiple vaultManagers

The changes made in commit cc2651a of branch alex/develop provide the 2 vaultManagers for 2 different assets for the test test-jorge-
The assertions for the Vstorage behaviour is still WiP.

IMPORTANT: the changes made to the setupServices function was following the logic of make it work and not make it good.
So I advise to refactor the code so it does not break the other tests cases or generate conflicts when merging to other branch

cc: @alexanderem49

…om the vstorage

…rtions for running the tests

…updated, #7 is fixed

…tupBasics

… schedule

…pdate file name

…e test

# This is the 1st commit message: create dedicated files for test assertions and tools # This is the commit message #2: Add new test file for liquidation visibility # This is the commit message #3: auctioneer snapshot # This is the commit message #4: Update visibility tests and helper functions # This is the commit message #5: add tools and assertions to match subscriber with vstorage data # This is the commit message #6: update test visibility of vault liquidation # This is the commit message #7: fix(liquidationVisibility): fix linting errors # This is the commit message #8: fix(liquidationVisibility): type error # This is the commit message #9: chore(liquidationVisibility): #4 testing tools setup # This is the commit message #10: chore(liquidationVisibility): #4 improve testing tools # This is the commit message #11: chore(liquidationVisibility): #4 improve testing tools # This is the commit message #12: fix(liquidationVisibility): linting fixes # This is the commit message #13: chore(liquidationVisibility): fix test names # This is the commit message #14: fix(liquidationVisibility): lint fix # This is the commit message #15: chore(liquidationVisibility): #4 implement `assertNodeInStorage` # This is the commit message #16: fix(liquidationVisibility): #4 lint fix # This is the commit message #17: chore(liquidationVisibility): #4 test skeleton is ready # This is the commit message #18: chore(liquidationVisibility): #4 add marshaller for comparing data from the vstorage # This is the commit message #19: chore(liquidationVisibility): sample test for `preAuction` and `postAuction` data fields # This is the commit message #20: chore(liquidationVisibility): make sure `assertStorageData` works # This is the commit message #21: chore(liquidationVisibility): #4 add test for case 2b, uncomment assertions for running the tests # This is the commit message #22: feat(liquidationVisibility): create liquidation storageNodes and recorderKits BREAKING CHANGE: Introduced the `_timestamp` as an argument for the vaultManager liquidateVaults method. feat(liquidationVisibility): write preAuctionState and auctionResultState to Vstorage BREAKING CHANGE: a getVaultId method was included in the Vault interface, which returns the vault `idInManager` fix(liquidationVisibility): fix type definitions errors and concurrently await multiple promises feat(liquidationVisibility): write postAuctionState to Vstorage BREAKING CHANGE: the getVaultId method of vaults interface was updated to getVaultState, which will return the vault phase as well chore(liquidationVisibility): update helper methods, type definitions and names fix(liquidationVisibility): lint fix fix(liquidationVisibility): update sequence to write auction state to Vstorage and its structure The helper methods built for this purpose became unnecessary and were removed. fix(liquidationVisibility): update postAuctionState structure and change to writeFinal recorder method fix(liquidationVisibility): remove temporary changes made to tests fix(liquidationVisibility): #4 test for scenario 2b passed, test api updated, #7 is fixed chore(liquidationVisibility): #4 test for scenario 2a passed chore(liquidationVisibility): #4 update scenario 1 Squashed commit of the following: commit 728d695 Author: anilhelvaci <anilhelvaci96@gmail.com> Date: Wed Jan 31 14:28:14 2024 +0300 chore(liquidationVisibility): uncomment post auction assertion in `liq-result-scenario-1` commit dd3fbdb Author: anilhelvaci <anilhelvaci96@gmail.com> Date: Wed Jan 31 14:25:22 2024 +0300 fix(liquidationVisibility): lint fix commit 6920d1a Author: anilhelvaci <anilhelvaci96@gmail.com> Date: Wed Jan 31 14:22:28 2024 +0300 fix(liquidationVisibility): explain Promise.allSettled commit 732e1d7 Author: anilhelvaci <anilhelvaci96@gmail.com> Date: Wed Jan 31 11:37:45 2024 +0300 feat(liquidationVisibility): handle errors that might arise from other vats commit 683f56d Author: anilhelvaci <anilhelvaci96@gmail.com> Date: Tue Jan 30 14:31:13 2024 +0300 feat(liquidationVisibility): add LiquidationVisibilityWriters to improve readability, fetch schedule during the auction itself commit 4c45f2a Author: anilhelvaci <anilhelvaci96@gmail.com> Date: Tue Jan 30 10:30:02 2024 +0300 fix(liquidationVisibility): add pattern matcher to `getVaultState` chore(liquidationVisibility): #4 add auctioneer wrapper and update setupBasics chore(liquidationVisibility): #4 add mock makeChainStorageNode chore(liquidationVisibility): #4 add tests for no vaults and rejected schedule fix(liquidationVisibility): #4 add setBlockMakeChildNode method and update file name fix(liquidationVisibility): #4 update import path chore(liquidationVisibility): #4 add liq-rejected-timestampStorageNode test fix(liquidationVisibility): #4 fix bug with at makeChildNode fix(liquidationVisibility): #4 update test names and comments fix(liquidationVisibility): #4 lint fix chore(internal): create key-value pairs for Promise.allSettled values fix(internal): make allValuesSettled a mapper for resolved promises and silently handles rejected ones fix(internal): fix doc fix(liquidationVisibility): make sure promises are assigned in key-value fashion, lint fixes. chore(liquidationVisibility): extend liq-rejected-timestampStorageNode and clean outdated comments fix(liquidationVisibility): revert update made to package.json chore(liquidationVisibility): update snapshot generated by unit tests fix(liquidationVisibility): lint fix chore(liquidationVisibility) #4 test multiple vaultManagers fix(liquidationVisibility): #4 lint fix fix(liquidationVisibility): add pattern matcher to `getVaultState` feat(liquidationVisibility): add LiquidationVisibilityWriters to improve readability, fetch schedule during the auction itself chore(liquidationVisibility): init work for bootstrap tests chore(liquidationVisibility): created test-liquidation-visibility.ts and started building a test suite chore(liquidationVisibility): upgrade tests are implemented. Refs: #15 fix(liquidationVisibility): vaults are now displayed in the correct order at `vaults.preAuction` Refs: #13 fix(liquidationVisibility): vault phases are now displayed correctly at `vaults.postAuction` Refs: #14 chore(liquidationVisibility): add storage snapshot Refs: #15 fix(liquidationVisibility): don't reverse `vaultData` for preAuction storage node Refs: #13

anilhelvaci added a commit that referenced this issue Jan 22, 2024

chore(liquidationVisibility): #4 testing tools setup

5dfa289

anilhelvaci added a commit that referenced this issue Jan 22, 2024

chore(liquidationVisibility): #4 improve testing tools

bbd2e48

anilhelvaci added a commit that referenced this issue Jan 22, 2024

chore(liquidationVisibility): #4 improve testing tools

7292068

anilhelvaci added a commit that referenced this issue Jan 22, 2024

chore(liquidationVisibility): #4 implement assertNodeInStorage

9fefcf0

anilhelvaci added a commit that referenced this issue Jan 22, 2024

fix(liquidationVisibility): #4 lint fix

e81df01

anilhelvaci added a commit that referenced this issue Jan 24, 2024

chore(liquidationVisibility): #4 test skeleton is ready

a5815ae

anilhelvaci added a commit that referenced this issue Jan 24, 2024

chore(liquidationVisibility): #4 add marshaller for comparing data fr…

51eb929

…om the vstorage

anilhelvaci added a commit that referenced this issue Jan 25, 2024

chore(liquidationVisibility): #4 add test for case 2b, uncomment asse…

b7cdb13

…rtions for running the tests

anilhelvaci added a commit that referenced this issue Jan 25, 2024

fix(liquidationVisibility): #4 test for scenario 2b passed, test api …

34ecf5c

…updated, #7 is fixed

anilhelvaci added a commit that referenced this issue Jan 25, 2024

chore(liquidationVisibility): #4 test for scenario 2a passed

348707e

alexanderem49 added a commit that referenced this issue Jan 26, 2024

chore(liquidationVisibility): #4 update scenario 1

e7259fb

anilhelvaci mentioned this issue Jan 29, 2024

Liquidation Visibility - Iteration One #9

Merged

Jorge-Lopes added a commit that referenced this issue Feb 1, 2024

chore(liquidationVisibility): #4 add auctioneer wrapper and update se…

9d45370

…tupBasics

Jorge-Lopes added a commit that referenced this issue Feb 1, 2024

chore(liquidationVisibility): #4 add mock makeChainStorageNode

b26f661

Jorge-Lopes added a commit that referenced this issue Feb 1, 2024

chore(liquidationVisibility): #4 add tests for no vaults and rejected…

575302c

… schedule

Jorge-Lopes added a commit that referenced this issue Feb 1, 2024

fix(liquidationVisibility): #4 add setBlockMakeChildNode method and u…

6d332b1

…pdate file name

Jorge-Lopes added a commit that referenced this issue Feb 1, 2024

fix(liquidationVisibility): #4 update import path

6732555

Jorge-Lopes added a commit that referenced this issue Feb 1, 2024

chore(liquidationVisibility): #4 add liq-rejected-timestampStorageNod…

e4a4c7b

…e test

Jorge-Lopes added a commit that referenced this issue Feb 1, 2024

fix(liquidationVisibility): #4 fix bug with at makeChildNode

031f791

Jorge-Lopes added a commit that referenced this issue Feb 1, 2024

fix(liquidationVisibility): #4 update test names and comments

6f25fe3

Jorge-Lopes added a commit that referenced this issue Feb 1, 2024

fix(liquidationVisibility): #4 lint fix

1e582d9

Jorge-Lopes mentioned this issue Feb 2, 2024

Extend liquidation visibility unit tests #12

Merged

Jorge-Lopes added a commit that referenced this issue Feb 2, 2024

chore(liquidationVisibility) #4 test multiple vaultManagers

cc2651a

alexanderem49 added a commit that referenced this issue Feb 8, 2024

chore(liquidationVisibility) #4 test multiple vaultManagers

8b2dcd8

alexanderem49 added a commit that referenced this issue Feb 8, 2024

fix(liquidationVisibility): #4 lint fix

82fd79d

anilhelvaci added a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 testing tools setup

c8ecb87

anilhelvaci added a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 improve testing tools

20fbb01

anilhelvaci added a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 improve testing tools

48d36a5

anilhelvaci added a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 implement assertNodeInStorage

7628d6e

anilhelvaci added a commit that referenced this issue Feb 16, 2024

fix(liquidationVisibility): #4 lint fix

a39f547

anilhelvaci added a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 test skeleton is ready

b441bff

anilhelvaci added a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 add marshaller for comparing data fr…

bdfaa79

…om the vstorage

anilhelvaci added a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 add test for case 2b, uncomment asse…

1ef0e24

…rtions for running the tests

anilhelvaci added a commit that referenced this issue Feb 16, 2024

fix(liquidationVisibility): #4 test for scenario 2b passed, test api …

6efea84

…updated, #7 is fixed

anilhelvaci added a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 test for scenario 2a passed

076a2f0

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 update scenario 1

fcaf76d

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 add auctioneer wrapper and update se…

f67ceea

…tupBasics

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 add mock makeChainStorageNode

3da0761

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 add tests for no vaults and rejected…

f382c43

… schedule

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

fix(liquidationVisibility): #4 add setBlockMakeChildNode method and u…

97493ba

…pdate file name

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

fix(liquidationVisibility): #4 update import path

f14bef7

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility): #4 add liq-rejected-timestampStorageNod…

d8f95e6

…e test

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

fix(liquidationVisibility): #4 fix bug with at makeChildNode

3c3878b

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

fix(liquidationVisibility): #4 update test names and comments

510733b

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

fix(liquidationVisibility): #4 lint fix

6c532f0

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

chore(liquidationVisibility) #4 test multiple vaultManagers

d302cbc

anilhelvaci pushed a commit that referenced this issue Feb 16, 2024

fix(liquidationVisibility): #4 lint fix

4aa211a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test Cases #4

Test Cases #4

anilhelvaci commented Jan 19, 2024 •

edited

Loading

anilhelvaci commented Jan 19, 2024

Jorge-Lopes commented Jan 29, 2024

Jorge-Lopes commented Feb 1, 2024 •

edited

Loading

Jorge-Lopes commented Feb 2, 2024

Test Cases #4

Test Cases #4

Comments

anilhelvaci commented Jan 19, 2024 • edited Loading

To begin with

anilhelvaci commented Jan 19, 2024

Generic assertions

Jorge-Lopes commented Jan 29, 2024

Test coverage (unit test)

Jorge-Lopes commented Feb 1, 2024 • edited Loading

Jorge-Lopes commented Feb 2, 2024

Unit test: multiple vaultManagers

anilhelvaci commented Jan 19, 2024 •

edited

Loading

Jorge-Lopes commented Feb 1, 2024 •

edited

Loading