Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.8.2 #98

Merged
merged 57 commits into from
Sep 25, 2018
Merged

v1.8.2 #98

merged 57 commits into from
Sep 25, 2018

Conversation

JoryHogeveen
Copy link
Owner

@JoryHogeveen JoryHogeveen commented Aug 17, 2018 •
edited
Loading

  • Enhancement/Fix: Support AJAX search in the Role Defaults module. Module: Role Defaults doesn't support user ajax search #100
  • Enhancement: Add support for X-Redirect-By header since WordPress 5.0. #42313
  • Enhancement: Improve uninstall script.
  • Enhancement: Use latest WPCS v1.1 update and fix code standard notices.
  • UI: Change the default top level node text to "View As" (same as Facebook uses).
  • Updated: Screenshots

@JoryHogeveen JoryHogeveen added this to the 1.8.2 milestone Aug 17, 2018
@JoryHogeveen JoryHogeveen self-assigned this Aug 17, 2018
@JoryHogeveen
x_redirected_by (WP 5.0)
b39221c 
Use text domain as identifier
@JoryHogeveen
Change default view node text similar to Facebook
40bb4a5
@JoryHogeveen
Update screenshots
ee7ac59
@JoryHogeveen
Capitalize
f2c5478
@JoryHogeveen
Use is_enabled() method
3c251b0
@JoryHogeveen
Refactor (simplify) validate_user()
027f1e2
@JoryHogeveen
Code standards
beade76
@JoryHogeveen
Allow message only when adding a notice
83d5b83
@JoryHogeveen
Support other return types for ajax search users.
793c847
@JoryHogeveen
Filter the return JSON data for ajax search users by return type.
b7d9f4e 
Filter: `view_admin_as_ajax_search_users_return_{RETURN_TYPE}`
@JoryHogeveen
Use pre-init hook to allow modules to filter ajax return.
eea444e
@JoryHogeveen
Bulk apply to users isn't depending on users but only on roles.
e6a3b5b 
#100
@JoryHogeveen
Add search nodes for ajax compatibility
6b71966 
#100
@JoryHogeveen
Filter ajax search terun for role defaults (bulk users apply)
4ad6809 
#100
@JoryHogeveen
Refactor ajax user search to a more general method
197c3f7 
#100
@JoryHogeveen
Pass empty value to reset results container
d8564ed
@JoryHogeveen
Option to pass a callback function instead of an results container el…
ac2fbb1 
…ement
@JoryHogeveen
Ajax user search for role defaults bulk actions
a5c3ef5 
#100
@JoryHogeveen
Reset if no search value is provided.
de0222c
JoryHogeveen
JoryHogeveen commented Sep 20, 2018
View reviewed changes
includes/class-settings.php
$settings, $current, $defaults, $allowed
);
$filter = 'view_admin_as_update_' . $type . '_settings' . $this->_filter_postfix;
$settings = apply_filters( $filter, $settings, $current, $defaults, $allowed );
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document this

@JoryHogeveen JoryHogeveen merged commit 96e5efb into master Sep 25, 2018
@JoryHogeveen JoryHogeveen changed the title 1.8.2 v1.8.2 Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoryHogeveen JoryHogeveen

Labels
bug enhancement maintenance module
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
1 participant
@JoryHogeveen