Updates from Kentico repo

KInspector.Modules/Kentico.KInspector.Modules.csproj

@@ -114,8 +114,12 @@
     <Compile Include="Modules\Content\NumberOfAliasesModule.cs" />
     <Compile Include="Modules\Content\RobotsTxtModule.cs" />
     <Compile Include="Modules\Content\PageTypeAssignedToSiteModule.cs" />
+    <Compile Include="Modules\Content\UnusedPageTypesModule.cs" />
+    <Compile Include="Modules\Content\UnusedTemplatesModule.cs" />
     <Compile Include="Modules\Content\WebPartsInTransformationsModule.cs" />
     <Compile Include="Modules\Content\WorkflowConsistencyModule.cs" />
+    <Compile Include="Modules\General\TaskProcessingIssuesModule.cs" />
+    <Compile Include="Modules\General\DebugCheckModule.cs" />
     <Compile Include="Modules\EventLog\EventLogErrorsModule.cs" />
     <Compile Include="Modules\Content\DuplicatePageAliasesModule.cs" />
     <Compile Include="Modules\EventLog\EventLogSizeModule.cs" />
@@ -139,6 +143,8 @@
     <Compile Include="Modules\OnlineMarketing\OMInactiveContactsDeletion.cs" />
     <Compile Include="Modules\OnlineMarketing\OMNewslettersWithoutQueue.cs" />
     <Compile Include="Modules\OnlineMarketing\OMTablesSize.cs" />
+    <Compile Include="Modules\General\DisabledWebPartAnalyzer.cs" />
+    <Compile Include="Modules\Security\ClickJackingModule.cs" />
     <Compile Include="Modules\Security\DataStructures\VulnerabilityAnalysisResults.cs" />
     <Compile Include="Modules\Security\FloodProtectionModule.cs" />
     <Compile Include="Modules\Security\PasswordPolicyModule.cs" />
@@ -202,6 +208,12 @@
     <Content Include="ProbeData\CMSPages\KInspectorProbe.aspx">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
+    <Content Include="Scripts\DisabledWebPartAnalyzerModule.sql">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </Content>
+    <Content Include="Scripts\DebugCheckModule.sql">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </Content>
     <Content Include="Scripts\FloodProtectionModule.sql">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
@@ -211,9 +223,30 @@
     <Content Include="Scripts\PageTypeFieldsDataTypeMismatchModule.sql">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
+    <Content Include="Scripts\Setup\GlobalAdminSetupModule-V10.sql">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </Content>
     <Content Include="Scripts\Setup\GlobalAdminSetupModule.sql">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
+    <Content Include="Scripts\TaskProcessingIssueModule.sql">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </Content>
+    <Content Include="Scripts\TransformationAnalyzerModule-GetDataWhereIn-KI_ClassNames.sql">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </Content>
+    <Content Include="Scripts\TransformationAnalyzerModule-Initialize-KI_ClassNames.sql">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </Content>
+    <Content Include="Scripts\TransformationAnalyzerModule-Initialize-KI_TransformationList.sql">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </Content>
+    <Content Include="Scripts\UnusedPageTypesModule.sql">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </Content>
+    <Content Include="Scripts\UnusedTemplatesModule.sql">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </Content>
     <Content Include="Scripts\WebPartColumnsModule9.sql">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
@@ -244,7 +277,7 @@
     <Content Include="Scripts\PasswordPolicy.sql">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
-    <Content Include="Scripts\TransformationAnalyzerModule-TransformationCodes.sql">
+    <Content Include="Scripts\TransformationAnalyzerModule-GetDataWhereIn-KI_TransformationList.sql">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
     <Content Include="Scripts\TransformationAnalyzerModule-PageTemplateWebParts.sql">
@@ -348,7 +381,7 @@
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
     <Content Include="Scripts\DocumentsConsistencyIssuesModule.sql">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>
     <Content Include="Scripts\UsersWithEmptyPasswordsModule.sql">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>

KInspector.Modules/Modules/Content/AttachmentsBySizeModule.cs

@@ -16,7 +16,8 @@ public ModuleMetadata GetModuleMetadata()
                     new Version("8.0"), 
                     new Version("8.1"),
                     new Version("8.2"),
-                    new Version("9.0")
+                    new Version("9.0"),
+                    new Version("10.0")
                 },
                 Comment = 
 @"Displays report of all attachments ordered by their size.

KInspector.Modules/Modules/Content/DBFileConsistencyModule.cs

@@ -16,8 +16,6 @@ public ModuleMetadata GetModuleMetadata()
 			{
 				Name = "Form Attachments and Media Library Consistency Check",
 				SupportedVersions = new[] {
-					new Version("6.0"),
-					new Version("7.0"),
 					new Version("8.0"),
 					new Version("8.1"),
 					new Version("8.2"),
@@ -368,14 +366,21 @@ public static FileInfo[] GetFiles(string baseUri, bool recursive, IInstanceInfo
 					throw new ArgumentNullException($"baseUri value is null");
 				}
 
-				if(baseUri.StartsWith("~/"))
+				try
+				{
+					if(baseUri.StartsWith("~/"))
+					{
+						var absPath = Combine(info.Directory.FullName, baseUri.Substring(2));
+						return Directory.Exists(absPath) ? new DirectoryInfo(absPath).GetFiles("*", recursive ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly) : new FileInfo[] { };
+					}
+					else
+						return Directory.Exists(baseUri) ? new DirectoryInfo(baseUri).GetFiles("*", recursive ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly) : new FileInfo[] { };
+				}
+				catch(Exception ex)
 				{
-					var absPath = Combine(info.Directory.FullName, baseUri.Substring(2));
-					return new DirectoryInfo(absPath).GetFiles("*", recursive ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly);
+					throw ex;
 				}
-				else
-					return new DirectoryInfo(baseUri).GetFiles("*", recursive ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly);
-			}
+	}
 
 			/// <summary>
 			/// Combines a base url with a list of folders afterwards.

KInspector.Modules/Modules/Content/DuplicatePageAliasesModule.cs

@@ -18,7 +18,8 @@ public ModuleMetadata GetModuleMetadata()
                     new Version("8.0"), 
                     new Version("8.1"), 
                     new Version("8.2"),
-                    new Version("9.0")
+                    new Version("9.0"),
+                    new Version("10.0")
                 },
                 Comment = @"Checks that the CMS_DocumentAlias table does not contain any duplicates.",
                 Category = "Content"

KInspector.Modules/Modules/Content/NumberOfAliasesModule.cs

@@ -16,7 +16,9 @@ public ModuleMetadata GetModuleMetadata()
                     new Version("8.0"), 
                     new Version("8.1"),
                     new Version("8.2"),
-                    new Version("9.0") },
+                    new Version("9.0"),
+                    new Version("10.0")
+                },
                 Comment = @"Returns number of aliases per node + total count of aliases and documents for direct comparison.
 
 Having too many aliases per node may suggest problem with wrong API usage, decreased performance and SEO problems. 

KInspector.Modules/Modules/Content/PageTypeAssignedToSiteModule.cs

@@ -16,7 +16,8 @@ public ModuleMetadata GetModuleMetadata()
                     new Version("8.0"), 
                     new Version("8.1"), 
                     new Version("8.2"),
-                    new Version("9.0")
+                    new Version("9.0"),
+                    new Version("10.0")
                 },
                 Comment = @"Displays page types used by a certain site without being assigned to this site.
 

KInspector.Modules/Modules/Content/SiteTemplatesModule.cs

@@ -60,15 +60,16 @@ public ModuleMetadata GetModuleMetadata()
         {
             return new ModuleMetadata
             { 
-                Name = "Site templates",
+                Name = "Page template overview",
                 SupportedVersions = new[] {
                     new Version("7.0"),
                     new Version("8.0"), 
                     new Version("8.1"), 
                     new Version("8.2"),
-                    new Version("9.0")
+                    new Version("9.0"),
+                    new Version("10.0")
                 },
-                Comment = @"Analyzes all templates used on sites.",
+                Comment = @"Shows the basic web part configuration for all page templates and lists all the documents that use that template.",
             };
         }
 
@@ -89,17 +90,24 @@ public ModuleResults GetResults(IInstanceInfo instanceInfo)
                 if (results.Tables.Contains(templateName))
                 {
                     // Page template code names should be unique
-                    templateName += " - DUPLICATE CODENAME (ID: " + template["PageTemplateID"] + ")";
+                    templateName += $" - DUPLICATE CODENAME, ID: {template["PageTemplateID"]}";
                     duplicateTemplateCodeName = true;
                 }
-                DataTable result = GetTableForTemplateResult(templateName);
+
+                var tableHeader = $"{template["PageTemplateDisplayName"]} [{templateName}]";
+
+                DataTable result = GetTableForTemplateResult(tableHeader);
 
                 if (templateWP.WebPartZones != null)
                 {
                     foreach (var zone in templateWP.WebPartZones)
                     {
                         if (zone.WebParts == null || zone.WebParts.Length == 0)
                         {
+                            var row = result.NewRow();
+                            row["WebPartTitle"] = "No web parts";
+                            row["Zone"] = zone.ID;
+                            result.Rows.Add(row);
                             continue;
                         }
                         foreach (var wp in zone.WebParts)
@@ -138,12 +146,18 @@ public ModuleResults GetResults(IInstanceInfo instanceInfo)
                         }
                     }
                 }
+                else
+                {
+                    var row = result.NewRow();
+                    row["WebPartTitle"] = "No web part zones";
+                    result.Rows.Add(row);
+                }
 
                 results.Tables.Add(result);
 
                 var documents = dbService.ExecuteAndGetTableFromFile("SiteTemplatesModule-Documents.sql", 
                     new SqlParameter("PageTemplateID", template["PageTemplateID"]));
-                documents.TableName = $"{templateName} - Documents";
+                documents.TableName = $"{tableHeader} - Documents";
                 results.Tables.Add(documents.Copy());
             }
 
@@ -171,9 +185,9 @@ protected TemplateWebParts GetTemplateWebPartsFromXML(string xml)
             }
         }
 
-        protected DataTable GetTableForTemplateResult(string templateName)
+        protected DataTable GetTableForTemplateResult(string tableName)
         {
-            DataTable result = new DataTable(templateName);
+            DataTable result = new DataTable(tableName);
             result.Columns.Add("WebPartTitle");
             result.Columns.Add("WebPartType");
             result.Columns.Add("ID");

KInspector.Modules/Modules/Content/TreeNodeChildrenModule.cs

@@ -16,7 +16,8 @@ public ModuleMetadata GetModuleMetadata()
                     new Version("8.0"), 
                     new Version("8.1"), 
                     new Version("8.2"),
-                    new Version("9.0")
+                    new Version("9.0"),
+                    new Version("10.0")
                 },
                 Comment = @"Displays TreeNodes having more than 1000 children.
 

KInspector.Modules/Modules/Content/UnusedPageTypesModule.cs

@@ -0,0 +1,41 @@
+using System;
+using System.Data;
+using System.Data.SqlClient;
+using System.IO;
+using System.Linq;
+using System.Xml.Serialization;
+using Kentico.KInspector.Core;
+
+namespace Kentico.KInspector.Modules
+{
+    public class UnusedPageTypesModule : IModule
+    {
+        public ModuleMetadata GetModuleMetadata()
+        {
+            return new ModuleMetadata
+            {
+                Name = "Unused page types",
+                SupportedVersions = new[] {
+                    new Version("8.0"), 
+                    new Version("8.1"), 
+                    new Version("8.2"),
+                    new Version("9.0"),
+                    new Version("10.0")
+                },
+                Comment = @"Looks for unused page types.",
+            };
+        }
+
+
+        public ModuleResults GetResults(IInstanceInfo instanceInfo)
+        {
+            var dbService = instanceInfo.DBService;
+            var unusedTemplates = dbService.ExecuteAndGetTableFromFile("UnusedPageTypesModule.sql");
+
+            return new ModuleResults
+            {
+                Result = unusedTemplates
+            };
+        }
+    }
+}

KInspector.Modules/Modules/Content/UnusedTemplatesModule.cs

@@ -0,0 +1,41 @@
+using System;
+using System.Data;
+using System.Data.SqlClient;
+using System.IO;
+using System.Linq;
+using System.Xml.Serialization;
+using Kentico.KInspector.Core;
+
+namespace Kentico.KInspector.Modules
+{
+    public class UnusedTemplatesModule : IModule
+    {
+        public ModuleMetadata GetModuleMetadata()
+        {
+            return new ModuleMetadata
+            {
+                Name = "Unused templates",
+                SupportedVersions = new[] {
+                    new Version("8.0"), 
+                    new Version("8.1"), 
+                    new Version("8.2"),
+                    new Version("9.0"),
+                    new Version("10.0")
+                },
+                Comment = @"Looks for unused templates.",
+            };
+        }
+
+
+        public ModuleResults GetResults(IInstanceInfo instanceInfo)
+        {
+            var dbService = instanceInfo.DBService;
+            var unusedTemplates = dbService.ExecuteAndGetTableFromFile("UnusedTemplatesModule.sql");
+
+            return new ModuleResults
+            {
+                Result = unusedTemplates
+            };
+        }
+    }
+}

KInspector.Modules/Modules/Content/WebPartsInTransformationsModule.cs

@@ -27,7 +27,8 @@ You should use hierarchical transformation instead (see https://docs.kentico.com
                     new Version("8.0"), 
                     new Version("8.1"), 
                     new Version("8.2"),
-                    new Version("9.0")
+                    new Version("9.0"),
+                    new Version("10.0")
                 },
                 Category = "Content",
             };