Do save cookies should put only the names and their values to requests #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 8, 2024 12:41
…he upcoming requests (strip everything else, e.g., samesite, path)
…ues to the upcoming requests (strip everything else, e.g., samesite, path)
|
Hey @RoGer2856 , thanks for finding this and providing a PR. I'll merge and release this now. Sorry for the delays in looking at this. |
|
Hi,
No problem.
Thanks for merging it :)
…On Thu, Aug 15, 2024 at 3:59 PM Joseph Lenton ***@***.***> wrote:
Merged #89 <#89> into main.
—
Reply to this email directly, view it on GitHub
<#89 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA45UK2IA5YHRQNKF2QCYILZRSX3TAVCNFSM6AAAAABMGHTNO6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHA4TMMJXHE2TEOI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the HTTP State Management RFC,
cookieheader fields are in format:<cookie-name>=<cookie-value>. Optionally multiple cookies can be defined in onecookieheader separated semicolons.The
set-cookieheader uses semicolons for separating different attributes (e.g., path, domain, samesite). Sending attributes in the cookie header causes parsing problems in middlewares and request handlers. EvenCookieJarassumes, that cookies are separated by a semicolon, therefore it tries to parse the attributes individally.This pull request contains some tests for these issues, and fixes the problem.