Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl_global should call cleanup in destructor #103

Closed
sergey-shambir opened this issue May 10, 2017 · 3 comments
Closed

curl_global should call cleanup in destructor #103

sergey-shambir opened this issue May 10, 2017 · 3 comments
Assignees
@sergey-shambir

Comments

@sergey-shambir
Copy link

CURL uses counter for init/cleanup calls. So calling cleanup from curl_global is safe, but if it doesn't call cleanup, it breaks counter.
@sergey-shambir
Copy link
Author

I'm going to provide pull request on next weekend.

@JosephP91
Copy link
Owner

Awesome! :)

sergey-shambir pushed a commit to sergey-shambir/curlcpp that referenced this issue Jun 1, 2017
Disabled copying for curl_global, added curl_global_cleanup call in d…
f758a48 
…estructor

Also moved function definitions to cpp file
Fix for issue "curl_global should call cleanup in destructor" JosephP91#103
@sergey-shambir sergey-shambir mentioned this issue Jun 1, 2017
Merged
@sergey-shambir
Copy link
Author

So it's time to close issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergey-shambir sergey-shambir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sergey-shambir @JosephP91