Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed curl_pair<CURLformoption,string> handling of string constants #115

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Fixed curl_pair<CURLformoption,string> handling of string constants #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions include/curl_pair.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,12 @@ namespace curl {
* The two parameters constructor gives users a fast way to
* build an object of this type.
*/
curl_pair(const CURLformoption option, const std::string &value) : option(option), value(value) {}
curl_pair(const CURLformoption option, const std::string &value) : option(option), value(value.c_str()) {}
/**
* Alternate constructor that handles string constants without
* referencing temporary objects.
*/
curl_pair(const CURLformoption option, const char *value) : option(option), value(value) {}
/**
* Simple method that returns the first field of the pair.
*/
Expand All @@ -86,11 +91,11 @@ namespace curl {
* a C string, so a const char *.
*/
inline const char *second() const NOEXCEPT {
return this->value.c_str();
return this->value;
}
private:
const CURLformoption option;
const std::string &value;
const char* value;
};

/**
Expand Down