Add autocapitalize prop to UiTextbox
#501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really I think I'd prefer to pass through some form of key value map like in React so this doesn't need editing per-new attribute. Is that possible?
|
Looks good. Will merge for next release. Thanks! |
JosephusPaye
approved these changes
Feb 10, 2021
|
Haha. Any updates on merge. If I remember correctly, this is how I came to the repo. Kolibri uses / used this and as well as patching their local fork, I wanted to offer to upstream this after one of their users or devs raised an issue regarding autocapitalize on mobile. |
JosephusPaye
changed the title
autocapitalize prop to UiTextbox
|
Thanks! |
|
Released in v1.3.2 |
|
Well Happy New Year to you and thanks. |
|
Happy New Year! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500
Update: Now has documentation updates to showcase autocapitalize attribute
yarn devand openinghttp://127.0.0.1:9000