Fix UiSwitch thumb overlapping an open modal #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jeff-hykin, Thanks for the PR! Were you able to check with other browsers to confirm that it works? Happy to merge this if there's no regression. |
|
Yes, should work on any browser that merely implements the HTML 5 specification, tested on Firefox and Chrome. The original z-index was only needed because the elements were out of order (probably on accident). |
|
Note there is a similar issue with ui-buttons having a z-index, but I can't confirm removing it doesn't cause side effects so it's not in this PR. I should probably open an issue for it |
JosephusPaye
approved these changes
Feb 10, 2021
JosephusPaye
changed the title
|
Thanks! |
|
Released in v1.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior (switch bleeds into model, even with modal
z-index: 99999)Behavior After
.ui-switch__thumb { z-index: unset }This PR Behavior (change element order instead of using z-index)