Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0 #47

Closed
17 tasks done
JoshCheek opened this issue Sep 15, 2014 · 2 comments
Closed
17 tasks done

v3.0 #47

JoshCheek opened this issue Sep 15, 2014 · 2 comments

Comments

@JoshCheek
Copy link
Owner

V3 is basically ready at this point. But I'm going to wait until my next break so I can try and make the editor integrations better. I figure a big version bump will get a little bit of attention, so it should be particularly slick when it rolls out. But I spent a lot of time on this (270 commits since I started my break) and want to spend the rest of it on https://github.com/JoshCheek/ruby_object_model_viewer


To accommodate the changes I want, should bump the major version. As long as I'm doing that, might as well stick in a bunch of things I want.

Code

Code is now on master, see the commits.
956bd0c..a38fcf4

Lots more stuff happened than is listed here. But I don't think anyone other than me cares about this, so not going to put the effort in to update it.

Features

Cleanup

  • Generally, tons of stuff happened here. A lot more than is listed.
  • Renamings in EventStream + split it out into multiple files
  • Rename CleanBody -> RemoveAnnotations
  • Refactor that POS AddAnnotations. Probably there are two objects in there, one for sib style, one for xmpfilter style, also, it is annoying that we get the result from AddAnnotations, it conceptually should take a file and a set of results, and add them on each line.
  • Make sure I actually like the Result class (I don't particularly, but it solves a relevant issue).
  • Probably get rid of the line class (the exception is already on Result, other than that it's just an array) completed
  • Parser fixed the heredoc bugs, so doesn't need the stupid hacks I wrote. Probably they are littered all over ParserHelpers and WrapExpressions
  • Figure out this encoding bullshit (Encoding variable is wrong #33)
  • Switch syntax checking to use Pry's trick (Switch syntax checking to use pry's trick #38)
  • Get rid of --start-line and --end-line and instead have maybe --show-lines, a comma-separated array of lines to display output on (e.g. I can't think of a start/end line use-case, but it makes sense to want to see the current line, but then show for multiple cursors or where a user has marked in their editor)

Other

Descoped

  • Add a changelog (I added one, but didn't keep it up)
  • Get it working on JRuby and Rbx (already put a lot of work into this, but a bug in current version of JRuby, and inability to install Rbx due to not having llvm are preventing me from getting it at the moment -- actually, I might try again, this worked for me)
  • Use custom evaluators to support safe mode (integration with eval_in) (I no longer intend to do this 17db7e9)
  • Expose ability to provide custom evaluators. (I only need one now. If anyone else needs one, they can ask me to do this. It shouldn't be hard, but don't see the need for the indirection at present.
  • auto-record rescued exceptions (seemed like a lot of work without an obvious benefit)
  • Track, for each line, what kind of obj it's recording (e.g. method def/literal/etc) and provide an interface for the user to specify what they would like to see. (going to have to wait until the next version, it's just going to take a lot of effort)
  • A hybrid chunk/file line aligner that tries to line everything up for the whole file, but will discard outliers that are fucking it up. (might still do this one)
  • Would be nice to find a way to deal with Atom identifying the file change too quickly. (yeah, idk what it would be)
  • Would be nice to bundle a ruby executable with the editor integrations so newbies can just install with the editor's package manager instead of having to configure everything. (Traveling Ruby was what I was thinking, but it doesn't support Windows)
JoshCheek added a commit that referenced this issue Sep 15, 2014
Not releasing it just yet, there's quite a bit more that should happen
JoshCheek added a commit that referenced this issue Sep 15, 2014
it's something I often want to see.
Part of 3.0 release (#47)
JoshCheek added a commit that referenced this issue Sep 20, 2014
Does not correctly remove it, yet, though.

This is part of #44 & #47
@JoshCheek
Copy link
Owner Author

TODO list is now primarily stored in the source code as "TODO" comments. Kinda stinks b/c you can't see it from the outside, but I find those a lot more engaging (ie I'm a lot more likely to actually do them).

JoshCheek added a commit that referenced this issue Jan 6, 2015
Closes #40
Part of #47
JoshCheek added a commit that referenced this issue Jan 16, 2015
No need to waste Travis's computers on these since I know I expect them to fail for now.
And I'm not working on them as I'm putting #31 on hold for a bit.
Also removing it from things to do for #47.

JRuby has an IO bug at the moment, it's causing EventStream tests to lock up.
jruby/jruby#2461
I could probably get around it by commenting them out, it's not for a case that I actually expect anyway.
But 9k Fixes this anyway, so wait for that to be common.

Rbx had a bug with how it was handling mass assignment.
The "rest" variable on this line https://github.com/JoshCheek/seeing_is_believing/blob/2ddca5d42c693e3028d574dcb74bcc1f654b068c/lib/seeing_is_believing/binary/remove_annotations.rb#L79
is nil when thre is only one subarray.
I had started to open a bug report, but realized m Rbx was a bit older.
So was going to upgrade and see if its still there, maybe try and fix it.
But I couldn't get it to install. Couldn't find llvm-config.
I'm on an older OS (Lion) since everyone had issues going to Yosemite, and don't feel like
going through the headache of upgrading just to get a newer llvm, just to get Rbx.
Plus apparently Apple is now tracking a lot more data, and you have to run some Python script
to turn it off or something, and IDK, this one is working sufficiently fine for me.
Oh, but I wound up uninstalling Rbx while attempting to upgrade, so now I don't
even have one that I can test against.

I'll probably come back to these when I have more time and it takes less effort.
@JoshCheek
Copy link
Owner Author

V3 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant