remove ip package #94
Conversation
package.json
Outdated
| @@ -23,7 +23,7 @@ | |||
| "socks5" | |||
| ], | |||
| "engines": { | |||
| "node": ">= 10.13.0", | |||
| "node": ">= 16.0.0", | |||
There was a problem hiding this comment.
dropping support for node version is a breaking change - it looks like ip-address v7 supports Node v10; would it be possible to use that instead?
There was a problem hiding this comment.
I think i'll just bump the overall package to 3.0.0. Anything prior to node 16.x isn't being maintained at this point.
There was a problem hiding this comment.
that'll mean downstream packages will need to explicitly update their dependency on sock to v3 (and require that they support node v16+) which could delay rollout - any chance of getting a final v2 patch with this before immediately releasing v3?
There was a problem hiding this comment.
btw If you're running into problems related to Node 10, I'm happy to have a crack at getting things working :)
There was a problem hiding this comment.
I think it may just be the typescript building not working on 10.x, the actual javascript may work fine tbh.
There was a problem hiding this comment.
Okay, yeah so it works just fine on plain javascript node 10.24.1 with ip-address 9.x, it's just the building of the typescript/etc won't work for anything less than 16.
There was a problem hiding this comment.
So I'll just leave the min version as-is with 10.x, and release as 2.8.0? Or should this just be a bug/patch as 2.7.2?
There was a problem hiding this comment.
I think technically it's a feature but I don't think anyone would complain if you released it as a bug fix 🤷
|
just want to say thanks for the fast response on this ❤️ |
|
Thank you for sorting this out so quickly, much appreciated! |
I don't think Dependabot opens a fix as it's still used by some dev dependencies, but this change reduces the scope by removing it from the deployed app. Refs JoshGlazebrook/socks#94, indutny/node-ip#150
No description provided.