Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Node 6 deprecated warnings #137

Merged
merged 2 commits into from
May 6, 2016
Merged

Fixes Node 6 deprecated warnings #137

merged 2 commits into from
May 6, 2016

Conversation

mwain
Copy link
Contributor

@mwain mwain commented May 6, 2016

Fixes v8::ObjectTemplate::Set() with non-primitive values is deprecated warnings for Node v6.
Using Nan::SetPrototypeMethod for bindings.

Fixes #135

@mwain mwain mentioned this pull request May 6, 2016
Closed
@quartzjer
Copy link
Collaborator

Nice!! Want to be maintainer? I inherited it and am not using the module anymore, haven't been able to keep up w/ the node revs :/

@quartzjer quartzjer merged commit f267892 into JoshKaufman:master May 6, 2016
@mwain
Copy link
Contributor Author

mwain commented May 6, 2016

No problem! Could you publish a release 👍

@mwain
Copy link
Contributor Author

mwain commented May 6, 2016 •
edited
Loading

  • Sorry by C++ is rusty, i only dabble. Don't mind picking up the odd issue to fix though?
    @quartzjer

@mwain mwain deleted the node-6-fixes branch May 6, 2016 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwain @quartzjer