fix: don't expand existing type with explicit any (#1279)

* fix: don't expand existing type with explicit any * fix: doc comment
JoshuaKGoldberg · Aug 18, 2023 · dea0ef7 · dea0ef7
1 parent dbc20ac
commit dea0ef7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/src/mutations/creators.ts b/src/mutations/creators.ts
@@ -23,6 +23,11 @@ export const createTypeAdditionMutation = (
     declaredType: ts.Type,
     allAssignedTypes: ReadonlyArray<ts.Type>,
 ): TextInsertMutation | TextSwapMutation | undefined => {
+    // Declared 'any' types inherently can't be incomplete
+    if (tsutils.isTypeFlagSet(declaredType, ts.TypeFlags.Any)) {
+        return undefined;
+    }
+
     // Find any missing flags and symbols (a.k.a. types)
     const { missingFlags, missingTypes } = collectUsageFlagsAndSymbols(request, declaredType, allAssignedTypes);
 

diff --git a/test/cases/fixes/incompleteTypes/parameterTypes/expected.ts b/test/cases/fixes/incompleteTypes/parameterTypes/expected.ts
@@ -9,4 +9,8 @@
     function passesStringOrBoolean(input: string | boolean) {
         takesStringOrBoolean(input);
     }
+
+    function takesAny(
+        input: any = {}
+    ) {}
 })()
diff --git a/test/cases/fixes/incompleteTypes/parameterTypes/original.ts b/test/cases/fixes/incompleteTypes/parameterTypes/original.ts
@@ -9,4 +9,8 @@
     function passesStringOrBoolean(input: string | boolean) {
         takesStringOrBoolean(input);
     }
+
+    function takesAny(
+        input: any = {}
+    ) {}
 })()