feat: split CJS and ESM outputs more formally #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
=======================================
Coverage 80.33% 80.33%
=======================================
Files 37 37
Lines 1119 1119
Branches 145 145
=======================================
Hits 899 899
Misses 220 220 ☔ View full report in Codecov by Sentry. |
JoshuaKGoldberg
commented
Aug 14, 2024
| rules: { | ||
| "package-json/sort-collections": "off", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Irksome conflict between the ESLint plugin and Prettier. I don't have the bandwidth to investigate right now.
|
🎉 This is included in version v0.5.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Previously, all outputs were in one
lib/directory. Now they're inlib/cjsandlib/esm. This way the package & its consumers don't have to deal with ambiguities in imports/requires around file extensions.💖