fix: Owner being replaced in github actions

[jaas666]

PR Checklist

• Addresses an existing open issue: fixes 🐛 Bug: Migrating a non-JoshuaKGoldberg repo creates the wrong owners for JoshuaKGoldberg actions #1043
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

This PR should fix #1043 Originally I wanted to go with a callback function to exclude certain strings from being replaced but that's above my pay grade.

I don't like the way we are excluding using regex but this should solve the issue in the meantime.

Someday I'll get to that level. 🤓

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c347e0b) 94.18% compared to head (1a6a0c9) 94.18%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files          96       96           
  Lines        5571     5574    +3     
  Branches      448      448           
=======================================
+ Hits         5247     5250    +3     
  Misses        323      323           
  Partials        1        1           

Flag	Coverage Δ
create	70.60% <0.00%> (-0.04%)	⬇️
initialize	41.87% <100.00%> (+0.03%)	⬆️
migrate	69.82% <100.00%> (+0.01%)	⬆️
unit	72.08% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JoshuaKGoldberg]

Yeah I see how you ended up here but:

• This isn't super scalable: there are likely going to be more and more actions over time.
• There's an action mentioned in the issue and not covered here, release-it-action

I think the callback method -or something else that doesn't create long regex- would be the way to go.

[jaas666]

I agree. I don't like this solution either.

I tried coming up with a solution using the callback which should work but I couldn't figure out the correct regex to use.

I know my problem was that I change the regex to match /JoshuaKGoldberg/g only so the function was always false.

This , along with a new excludedFromReplacements variable, was my original attempt. A clever regex should make this work right?

[
/JoshuaKGoldberg/g,(match: string) =>
excludedFromReplacements.some((e) =>
match.includes(e))
? Match
: options.owner,
]

[JoshuaKGoldberg]

Instead of /JoshuaKGoldberg/g, maybe /JoshuaKGoldberg(\/\w+)?/? That way it also captures what comes after the JoshuaKGoldberg/, if anything.

[jaas666]

Sorry. I get and F on this one. I've tried but got nowhere. I'm adding release-it-action to at least make the PR functional, but feel free to close it until someone can properly fix it if you want.

[JoshuaKGoldberg]

You got it - thanks for trying though! I really appreciate you putting the effort in. ❤️