Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adopt create engine's 'new' mode #1766

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 13, 2024

PR Checklist

Overview

Corresponding create PR: JoshuaKGoldberg/create#48

Adds src/ directory creation as part of Block initialize()s. Hooks up mode: "new" for the new runtime mode setting. As a result, createStructure no longer needs a manual src: createSrc().

I've been testing this with:

gh repo delete JoshuaKGoldberg/cta-create-testing-1 --yes; rm -rf ./cta-*; CTA_CREATE_ENGINE=true node ~/repos/create-typescript-app/bin/index.js --base common --owner JoshuaKGoldberg --repository cta-create-testing-1 --title "CTA Create Testing" --description "Testing, will delete."; code cta-create-testing-1

💖

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: adopt create engine's 'create' mode chore: adopt create engine's 'new' mode Dec 13, 2024
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 13, 2024 19:20
@JoshuaKGoldberg JoshuaKGoldberg merged commit 14b6e51 into main Dec 13, 2024
13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the create-mode-create branch December 13, 2024 19:29
Copy link

🎉 This is included in version v1.77.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant