chore: use set-github-repository-labels and populate-all-contributors-for-repository internally #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Dec 16, 2024
| @@ -68,10 +70,11 @@ export const outcomeLabels = [ | |||
| }, | |||
| { | |||
| color: "d73a4a", | |||
| description: "Something isn't working :( 🐛", | |||
| description: "Something isn't working 🐛", | |||
There was a problem hiding this comment.
Technically this is a behavior change in the repo. Heh. I'm curious if anybody will notice. The combo of an emoticon and an emoji bugs me.
JoshuaKGoldberg
commented
Dec 16, 2024
JoshuaKGoldberg
commented
Dec 16, 2024
| @@ -214,6 +214,7 @@ exports[`expected file changes > knip.json 1`] = ` | |||
| { | |||
| "$schema": "https://unpkg.com/knip@latest/schema.json", | |||
| - "entry": ["script/*e2e.js", "src/index.ts!", "src/**/*.test.*"], | |||
| - "ignoreDependencies": ["all-contributors-cli"], | |||
There was a problem hiding this comment.
I think it was coming in as a nested dev dependency before. Now that I've had to make it explicit in package.json, Knip is reporting it. Ah well.
JoshuaKGoldberg
force-pushed
the
set-github-repository-labels
branch
from
e108fae to
cb49cdf
Compare
|
🎉 This is included in version v1.77.1 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Brings on a few utilities I recently extracted:
These should all have the same functionality as before. This should be a
chore:PR, not afeat:orfix:.The utility here is that the latter two are now used as standalone scripts in onboarding to the "create" engine. I thought they'd be done as network requests (#1752), but in this way I found it a lot simpler to have them as standalone scripts (#1751, JoshuaKGoldberg/create#60).
💖